Skip to content

fix Platform logic #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2016
Merged

fix Platform logic #290

merged 1 commit into from
May 27, 2016

Conversation

@chunghe
Copy link

@chunghe chunghe commented May 27, 2016

should use Platform.OS to check.

@chunghe
Copy link
Author

chunghe commented May 27, 2016

i've encountered following fatal error and app crashes

FATAL EXCEPTION: mqt_native_modules
 Process: com.cnyes.android, PID: 20251
 com.facebook.react.modules.core.JavascriptException: undefined is not an object (evaluating 'this._containerMeasurements.width'), stack:
 updateTabPanel@665:1718
 updateView@665:1300
 <unknown>@665:2832
 <unknown>@51:588
 value@56:4238
 <unknown>@56:1996
 g@56:451
 value@56:1966
     at com.facebook.react.modules.core.ExceptionsManagerModule.showOrThrowError(ExceptionsManagerModule.java:90)
     at com.facebook.react.modules.core.ExceptionsManagerModule.reportFatalException(ExceptionsManagerModule.java:78)

@skv-headless skv-headless merged commit a07e8d4 into ptomasroos:master May 27, 2016
@skv-headless
Copy link
Collaborator

skv-headless commented May 27, 2016

animation much better btw

caglaruba pushed a commit to caglaruba/react-native-scrollable-tab-view that referenced this pull request Aug 22, 2019
Merge pull request ptomasroos#290 from chunghe/master
dd9383b 
fix Platform logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chunghe @skv-headless